Skip to content

Update netty version for compatibility/staying current#8945

Merged
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:netty-version-update
Apr 22, 2024
Merged

Update netty version for compatibility/staying current#8945
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:netty-version-update

Conversation

@sureshanaparti

@sureshanaparti sureshanaparti commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Description

This PR updates Netty to 4.1.100 for compatibility with the version of com.google.protobuf:protobuf-java that the mysql-connector updated here: #8753.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Apr 19, 2024
@sureshanaparti

sureshanaparti commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 19, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Apr 19, 2024
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@blueorangutan

blueorangutan commented Apr 19, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9320

@sureshanaparti

sureshanaparti commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 19, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov
borisstoyanov approved these changes Apr 19, 2024
View reviewed changes

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti

sureshanaparti commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@apache apache deleted a comment from blueorangutan Apr 19, 2024
@blueorangutan

blueorangutan commented Apr 19, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sureshanaparti sureshanaparti marked this pull request as ready for review April 19, 2024 13:16
@codecov-commenter

codecov-commenter commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.33%. Comparing base (cadbb56) to head (b112960).
Report is 4 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #8945      +/-   ##
============================================
+ Coverage     15.13%   18.33%   +3.19%     
- Complexity    13469    16843    +3374     
============================================
  Files          4863     4863              
  Lines        326031   326031              
  Branches      45838    45838              
============================================
+ Hits          49349    59770   +10421     
+ Misses       270066   257767   -12299     
- Partials       6616     8494    +1878
Flag Coverage Δ
simulator-marvin-tests 18.33% <ø> (+3.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

blueorangutan commented Apr 20, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9930)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52992 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8945-t9930-kvm-centos7.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 296.89 test_events_resource.py
test_01_events_resource Error 296.91 test_events_resource.py
test_08_upgrade_kubernetes_ha_cluster Failure 3672.76 test_kubernetes_clusters.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Failure 89.95 test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown Error 1.38 test_network_permissions.py

@DaanHoogland DaanHoogland merged commit 21182da into apache:4.19 Apr 22, 2024
@DaanHoogland DaanHoogland deleted the netty-version-update branch April 22, 2024 08:35
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@sureshanaparti @dhslove
Update netty version for compatibility/staying current (apache#8945)
59a0f7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@DaanHoogland DaanHoogland DaanHoogland approved these changes
@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

component:build component:secondary-storage component:ssvm

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@sureshanaparti @blueorangutan @codecov-commenter @yadvr @DaanHoogland @borisstoyanov